Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diceware-like passphrase generator #21

Closed
TheZ3ro opened this issue Oct 3, 2016 · 13 comments · Fixed by #373
Closed

Diceware-like passphrase generator #21

TheZ3ro opened this issue Oct 3, 2016 · 13 comments · Fixed by #373
Assignees
Milestone

Comments

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Oct 3, 2016

All the details in this PR for keepassx/keepassx keepassx/keepassx#181

@droidmonkey
Copy link
Member

Seems useful for edge cases, currently low priority.

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Oct 4, 2016

Can't we just "port" the changes in the PR from keepassx?

@davad
Copy link

davad commented Jan 26, 2017

I'd love to see this feature implemented. There are a few accounts that I like remembering a password, and passphrases are a nice way to create a memorable, high-entropy password.

What can I do to help get this feature implemented?

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Jan 26, 2017

I will start developing this in the next few days. Right now we are very busy fixing the 2.1.0 release

@davad
Copy link

davad commented Jan 26, 2017

@TheZ3ro If I have time before you get started, I'll see if I can rebase the PR from keepassx/keepassx#181

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Jan 26, 2017

If you do rebase that PR please maintain the commit history/authorship (e.g. cherry-pick)

@phoerious
Copy link
Member

For transferring old branches, git rebase --onto is usually the way to go.
But to be honest, I don't really like the user interface of that implementation over there.

@davad
Copy link

davad commented Jan 26, 2017

@phoerious It's not my favorite UI either, but we might as well use it as a starting point instead of beginning from scratch.

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Jan 26, 2017

Yes, we can make the UI like the current generator

@davad
Copy link

davad commented Jan 29, 2017

@phoerious I did the rebase without --onto. It was actually a pretty clean diff. I think there were only two commits with conflicts, and just a few conflicting lines in each.

I haven't compiled it yet. I'm building the docker image right now to see what it looks like.

@t4777sd
Copy link

t4777sd commented Feb 7, 2017

I think this is a GREAT feature. One question I have though is if we can specify the word list? For example, this is used a lot in cryptocurrency wallets. And, these wallets usually follow a standard where the words are selected from a predefined set: https://github.com/bitcoin/bips/blob/master/bip-0039/english.txt

So, using this extension, can we define the word-set that will be used when creating the phrased based password?

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Feb 7, 2017

I think it should be an option. It's not hard to implement since the wordlist is loaded from file

@aswolf
Copy link

aswolf commented Feb 13, 2017

I have also been looking for a feature like this for a long time! I am looking forward to its incorporation into KeePassXC!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants