Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to remove toolbar and replace icons with text labels #2343

Closed
accessibility-bug-reports opened this issue Oct 1, 2018 · 6 comments
Closed

Comments

@accessibility-bug-reports

Visual agnosia is a vision impairment that makes one unable to recognize things. Like icons. Also, a variety of conditions can cause difficulty discerning what tiny icons represent. This is a feature request for either the ability to remove the icons-only toolbar, to have the icons replaced with text labels, or preferably both.

Expected Behavior

Ideally, one would go into the settings and either check or uncheck "Show toolbar" or check "Icons only", "Icons and text", or "Text only". This would give more freedom in how people prefer to have their buttons, for whatever reason, or remove them entirely, if, for example, the system font size was large enough to make a toolbar impractical.

Current Behavior

At present, there is no apparent way to edit the toolbar, remove the toolbar, or change how the buttons on the toolbar are displayed. There is nothing in the settings menu, nor can you right click on the toolbar or a button to edit, which is more or less the two main ways of accomplishing this. (I can't find any settings about this anywhere, either.)

Possible Solution

I wish I knew enough to offer a potential way to fix this.

Context

I find the toolbar distracting. It also makes the program look more cluttered. I'd love if it could be removed entirely, since I'm used to using the menus. Though some text buttons would be nice, fewer mouse clicks that way. But if you did that, you'd need to make sure that what's included in the toolbar can be edited, because otherwise it wouldn't fit with the font size I use.

Debug Info

KeePassXC - 2.3.4
Revision: 6fe821c

Libraries:

  • Qt 5.11.1
  • libgcrypt 1.8.3

Operating system: Manjaro Linux
CPU architecture: x86_64
Kernel: linux 4.17.19-1-MANJARO

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey
@boppybibbles
Copy link
Contributor

@accessibility-bug-reports, as for version 2.4.0 there is a checkbox in settings to hide that toolbar.

Also I've tried experimenting with UI and looks like it is possible to get what you want with icons and labels. See screenshots below. I'll see if I will be able to make a proper PR for this.

image

image

@accessibility-bug-reports
Copy link
Author

accessibility-bug-reports commented Oct 4, 2018

@boppybibbles Sorry I wasn't clear, I meant this toolbar:

screenshot_20181003_213013

I almost never see that screen, since I have it set to remember the database. I didn't remember that there was a toolbar there.

I like the second image would be ideal, but both would work. I really appreciate it.

@boppybibbles
Copy link
Contributor

The toolbar is the same entity no matter which screen is visible at the moment.

boppybibbles pushed a commit to boppybibbles/keepassxc that referenced this issue Oct 5, 2018
- Add ability to change toolbar state and tool buttons style via
application settings widget.
- Save/restore toolbar state on app start/finish.
- Resolves keepassxreboot#2343.
droidmonkey pushed a commit to boppybibbles/keepassxc that referenced this issue Oct 28, 2018
- Add ability to change toolbar state and tool buttons style via
application settings widget.
- Save/restore toolbar state on app start/finish.
- Resolves keepassxreboot#2343.
droidmonkey pushed a commit that referenced this issue Jan 16, 2019
* Toolbar and tool buttons style.

- Add ability to change toolbar state and tool buttons style via
application settings widget.
- Save/restore toolbar state on app start/finish.
- Resolves #2343.

* Implicitly convert enum to QVariant
@EasyReader2
Copy link

EasyReader2 commented Feb 24, 2020

Hello droidmonkey,
I use Ubuntu MATE and Manjaro MATE. These desktops use GTK+. I just love big icons / buttons in the toolbar. With GTK+ applications, I have no problem. With qt5 applications, there are the following tools to help configure the appearance on GTK+: qt5ct and Kvantum Manager. I managed to use qt5ct to set the font size to 14, which helped, but then the original keepassxc icons were replaced by my theme icons. I renamed the respective qt5 config files in ~/.config and font size remained 14 (good!) and the orignal icons were back again (great!). Kvantum Manager did not help much in order to configure icon sizes in keepassxc. The icons in the toolbar are too small for my taste, both to distinguish and to click easily. Another painful example for small tool icons is notepadqq. If I remember correctly, Inkscape offers the possibility to scale up the icons in the toolbar. Could you give as such a possibilty in keepassxc too? Many thanks for your help.

@droidmonkey
Copy link
Member

Our work on the new UI design in 2.6.0 will likely solve all your issues here!

@EasyReader2
Copy link

EasyReader2 commented Feb 25, 2020

Thanks for the quick reply. I am really looking forward to the new release then :-)
Many thanks to the entire team for this great native, truely platform-independent tool. I really appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants