Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes field eats keyboard focus #4222

Closed
hifi opened this issue Jan 22, 2020 · 1 comment
Closed

Notes field eats keyboard focus #4222

hifi opened this issue Jan 22, 2020 · 1 comment
Labels
accessibility bug

Comments

@hifi
Copy link
Member

hifi commented Jan 22, 2020

When editing an entry. Going into the notes field with keyboard will eat focus forever as it will produce literal tab character with the tab key.

On Linux shift-tab works to go back but it doesn't help when you want to accept/cancel the entry edit with keyboard only. On Windows I have not found a way to get away from the field without mouse.

Expected Behavior

Tab key probably shouldn't be eaten by the editor, is it really necessary to produce literal tab characters in it?

Current Behavior

Focus is lost into notes field without mouse.

Possible Solution

Possibly correct solution would be to allow tab to work as normal rather than producing literal tab characters. Inelegant solution could be to create a custom binding like ctrl+tab to jump forward from this field only.

Steps to Reproduce

  1. Edit entry
  2. Focus notes field
  3. Press tab, press shift-tab

Context

For screen reader users this is a showstopper bug.

Debug Info

KeePassXC - 2.5.3
Repro on Windows and Linux
sjamesr added a commit to sjamesr/keepassxc that referenced this issue Jan 29, 2020
@sjamesr
Enable tab focus change in notes field.
a8b8ead 
Previously, if focus landed inside the Notes field in the Entry editor,
hitting 'tab' would insert a literal tab character. This is problematic
for those using screen readers. Now, hitting tab goes to the next
widget in the focus list.

Fixes keepassxreboot#4222.
@sjamesr sjamesr mentioned this issue Jan 29, 2020
Closed
@droidmonkey
Copy link
Member

I fixed this in 2.6.2, #5424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable tab focus change in notes field. sjamesr/keepassxc
2 participants
@hifi @droidmonkey