Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download favicon.ico not possible with port number in URL #5001

Closed
pvdl opened this issue Jul 9, 2020 · 2 comments · Fixed by #5509
Closed

Download favicon.ico not possible with port number in URL #5001

pvdl opened this issue Jul 9, 2020 · 2 comments · Fixed by #5509
Milestone
v2.7.0

Comments

@pvdl
Copy link

pvdl commented Jul 9, 2020 •
edited
Loading

Overview

Downloading a favicon.ico is not possible if an URL contains an port number.
Example: https://192.168.1.1:1234/favicon.ico

Steps to Reproduce

  1. Open in browser https://192.168.1.1:1234/favicon.ico (Favicon is visible, server listen to port 1234)
  2. Open in browser https://192.168.1.1/favicon.ico (Favicon is NOT visible, because server doesn't listen to port 443)
  3. Make an entry with https://192.168.1.1:1234/login (example)
  4. Select option 'Download Favicon' -> It shows a dialog with a status 'Download Failed'

Expected Behavior

In the last step 4 the favicon should be downloaded.

Actual Behavior

In the last step 4 the favicon is not downloaded, however it is accessible in a browser (Step 1)

Context

Probably the port number is not 'added' after the FQDN which is used to search the favicon.

KeePassXC - 2.6.0
Revision: REVISION

Operating System: Linux Mint 19.3 and macOS
Desktop Env: Cinnamon
Windowing System: X11/Wayland ???
@pvdl pvdl added the bug label Jul 9, 2020
@droidmonkey droidmonkey added this to the v2.6.2 milestone Aug 3, 2020
@pvdl
Copy link
Author

pvdl commented Sep 13, 2020

Maybe also a relation with issue #5419 ?

@droidmonkey
Copy link
Member

So you have a proxy setup?

@droidmonkey droidmonkey modified the milestones: v2.6.2, v2.7.0 Sep 27, 2020
libklein added a commit to libklein/keepassxc that referenced this issue Oct 4, 2020
@libklein
Fix favicon download from URL with non-standard port.
07306fd 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
@libklein libklein mentioned this issue Oct 4, 2020
Merged
libklein added a commit to libklein/keepassxc that referenced this issue Oct 10, 2020
@libklein
Fix favicon download from URL with non-standard port.
bc86711 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
libklein added a commit to libklein/keepassxc that referenced this issue Oct 11, 2020
@libklein
Fix favicon download from URL with non-standard port.
f7fb4cd 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
libklein added a commit to libklein/keepassxc that referenced this issue Oct 11, 2020
@libklein
Fix favicon download from URL with non-standard port.
c6eda71 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.

Added TestIconDownloader.cpp covering corner cases.
libklein added a commit to libklein/keepassxc that referenced this issue Dec 21, 2020
@libklein
Fix favicon download from URL with non-standard port.
642cc32 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
libklein added a commit to libklein/keepassxc that referenced this issue Dec 21, 2020
@libklein
Fix favicon download from URL with non-standard port.
a84a797 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.

Added TestIconDownloader.cpp covering corner cases.
droidmonkey pushed a commit to libklein/keepassxc that referenced this issue Mar 2, 2021
@libklein @droidmonkey
Fix favicon download from URL with non-standard port.
552532d 
Fixes keepassxreboot#5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
droidmonkey pushed a commit that referenced this issue Mar 2, 2021
@libklein @droidmonkey
Fix favicon download from URL with non-standard port.
57af7c1 
Fixes #5001.

The favicon download URL was constructed from scheme and host only. This is fixed by simply replacing the path of the original URL with "/favicon.ico", thus keeping scheme, host, auth and port intact.

Further modification: URL's with a non-http schema are now rejected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

Fix favicon download from URL with non-standard port. libklein/keepassxc
2 participants
@pvdl @droidmonkey