Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Move Up/Move Down resets entries columnset #5435

Closed
deflock opened this issue Sep 15, 2020 · 6 comments · Fixed by #5438
Closed

Using Move Up/Move Down resets entries columnset #5435

deflock opened this issue Sep 15, 2020 · 6 comments · Fixed by #5438
Labels
bug
Milestone
v2.6.2

Comments

@deflock
Copy link

deflock commented Sep 15, 2020

Steps to Reproduce

  1. Change columns settings
  2. Move any entry up or down
  3. Close application
  4. Open application
  5. Columns settings restored to defaults

Expected Behavior

000490

Actual Behavior

000491

Context

PORTABLE

KeePassXC - Version 2.6.1
Revision: 9a35bba

Qt 5.15.0
Debugging mode is disabled.

Operating system: Windows 10 Version 1903
CPU architecture: x86_64
Kernel: winnt 10.0.18362

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:
libgcrypt 1.8.5

000488
000489
@deflock deflock added the bug label Sep 15, 2020
@deflock deflock mentioned this issue Sep 15, 2020
Closed
@deflock
Copy link
Author

deflock commented Sep 15, 2020

Related #5327

@droidmonkey
Copy link
Member

droidmonkey commented Sep 16, 2020 •
edited
Loading

This bug is because we don't check to see if the logicalIndex is -1 which would indicate "no sort" and end up applying (forcing) a sort on startup. Easy fix, great find!

@droidmonkey
Copy link
Member

droidmonkey commented Sep 16, 2020 •
edited
Loading

Hmmm fix is a little more elusive then I expected. The no-sort (section index == -1) is not restored by Qt and ignored. Need to handle this special case somehow.

droidmonkey added a commit that referenced this issue Sep 16, 2020
@droidmonkey
Restore natural sort on application load
a487faa 
* Fixes #5435
@droidmonkey droidmonkey mentioned this issue Sep 16, 2020
Merged
@droidmonkey droidmonkey linked a pull request Sep 16, 2020 that will close this issue
Restore natural sort on application load #5438
Merged
@droidmonkey
Copy link
Member

Fix submitted

@droidmonkey droidmonkey added this to the v2.6.2 milestone Sep 16, 2020
@bulgin
Copy link

bulgin commented Sep 5, 2021

So what's the exact fix?

@droidmonkey
Copy link
Member

Uh #5438... it's linked to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.6.2
Development

Successfully merging a pull request may close this issue.

Restore natural sort on application load keepassxreboot/keepassxc
3 participants
@droidmonkey @bulgin @deflock