Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries with references use window background color #860

Closed
NiceGuyIT opened this issue Aug 10, 2017 · 7 comments
Closed

Entries with references use window background color #860

NiceGuyIT opened this issue Aug 10, 2017 · 7 comments
Milestone

Comments

@NiceGuyIT
Copy link

Note: This is specific to Linux and possibly KDE.
When cloning an entry with "Replace username and password with references" selected, the username and password are replaced with references like {REF:U@I:UID}. This causes the color of that entry to use the window background instead of a more appropriate color like inactive text, negative text, etc. This makes the text unreadable with a dark scheme.

Expected Behavior

The text should be readable.

Current Behavior

The text is unreadable due to the color used. I know it's not really the color, rather the widget property used to style the item. I'm not a GUI programmer and don't know the proper terminology.

Possible Solution

Style it with an appropriate color from the view color set.

Steps to Reproduce (for bugs)

  1. Use KDE on Linux.
  2. Change the color scheme to a dark color scheme. System Settings -> Appearance -> Colors
  3. Clone an entry and select the option to use references. OR add {REF:U@I:UID} to the username and reopen KeePassXC.
  4. Notice the unreadable text.

Context

I can't read entries with references.

Debug Info

KeePassXC - Version 2.2.0 (2.2.0-15.1 from the openSUSE repository)
Revision: caa49a8

Libraries:

  • Qt 5.6.1
  • libgcrypt 1.6.1

Operating system: openSUSE Leap 42.2
CPU architecture: x86_64
Kernel: linux 4.4.74-18.20-default

Enabled extensions:

  • KeePassHTTP
  • Auto-Type
  • YubiKey

Screenshots

This is the Obsidian Coast scheme. The 3rd entry is highlighted.
image

If I change the Window Background to green...
image

I get green text.
image

Other info

I have Apply colors to non-Qt applications checked.

Here's the KDE version from KInfocenter.

  • KDE Plasma Version: 5.8.6
  • KDE Frameworks Version: 5.26.0
@szymonbultrowicz
Copy link

Any update to this issue? It also occurs on MacOS Mojave 10.14.3
image

@droidmonkey droidmonkey added this to the v2.4.1 milestone Feb 5, 2019
@maniattico
Copy link

Same issue here in Manjaro Linux with KDE Plasma 5.14.5 and gnome 3.28.

keepassxc

@kingfame
Copy link

Any update? Since 2.4.0 will use dark mode when enabled in Mojave this is a huge problem, as 80% of my entries use references and they are not readable anymore:

image

droidmonkey added a commit that referenced this issue Apr 11, 2019
* Introduce macUtils()->isDarkMode() fuction
* Fixes #860
phoerious pushed a commit that referenced this issue Apr 12, 2019
Introduce macUtils()->isDarkMode() function to detect Mojave dark
mode and correct reference entry text color. Fixes #860.
@guixxx
Copy link

guixxx commented May 31, 2019

I'm still seeing this happening on KDE Plasma 15.5.5. I'm using the Breeze Transparent Dark theme:

image

Debug Info

KeePassXC - Version 2.4.1
Revision: 7bafe65

Qt 5.12.3
Debugging mode is disabled.

Operating system: Arch Linux
CPU architecture: x86_64
Kernel: linux 5.1.5-arch1-2-ARCH

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:
libgcrypt 1.8.4

@droidmonkey
Copy link
Member

This fix was specific to macOS.

@guixxx
Copy link

guixxx commented May 31, 2019

Oh, my bad. Should I open a new issue then?

@droidmonkey
Copy link
Member

Yes please. We need to have a more generic way of detecting "dark mode" across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants