-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entries with references use window background color #860
Comments
* Introduce macUtils()->isDarkMode() fuction * Fixes #860
Introduce macUtils()->isDarkMode() function to detect Mojave dark mode and correct reference entry text color. Fixes #860.
I'm still seeing this happening on KDE Plasma 15.5.5. I'm using the Breeze Transparent Dark theme: Debug InfoKeePassXC - Version 2.4.1 Qt 5.12.3 Operating system: Arch Linux Enabled extensions:
Cryptographic libraries: |
This fix was specific to macOS. |
Oh, my bad. Should I open a new issue then? |
Yes please. We need to have a more generic way of detecting "dark mode" across platforms. |
Note: This is specific to Linux and possibly KDE.
When cloning an entry with "Replace username and password with references" selected, the username and password are replaced with references like
{REF:U@I:UID}
. This causes the color of that entry to use the window background instead of a more appropriate color like inactive text, negative text, etc. This makes the text unreadable with a dark scheme.Expected Behavior
The text should be readable.
Current Behavior
The text is unreadable due to the color used. I know it's not really the color, rather the widget property used to style the item. I'm not a GUI programmer and don't know the proper terminology.
Possible Solution
Style it with an appropriate color from the view color set.
Steps to Reproduce (for bugs)
{REF:U@I:UID}
to the username and reopen KeePassXC.Context
I can't read entries with references.
Debug Info
KeePassXC - Version 2.2.0 (2.2.0-15.1 from the openSUSE repository)
Revision: caa49a8
Libraries:
Operating system: openSUSE Leap 42.2
CPU architecture: x86_64
Kernel: linux 4.4.74-18.20-default
Enabled extensions:
Screenshots
This is the Obsidian Coast scheme. The 3rd entry is highlighted.
If I change the Window Background to green...
I get green text.
Other info
I have Apply colors to non-Qt applications checked.
Here's the KDE version from KInfocenter.
The text was updated successfully, but these errors were encountered: