Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon download button next to URL field in entry edit #936

Closed
unimpededglare opened this issue Sep 10, 2017 · 4 comments · Fixed by #2439
Closed

Add favicon download button next to URL field in entry edit #936

unimpededglare opened this issue Sep 10, 2017 · 4 comments · Fixed by #2439
Assignees
@droidmonkey
Labels
user interface
Milestone
v2.4.0

Comments

@unimpededglare
Copy link

Expected Behavior

When adding a new entry, have a checkbox underneath the URL to "Download Favicon". KeePassXC would remember whether or not this box was checked for future entries. If this checkbox is checked, the Favicon would automatically be downloaded when the new entry is added.

Current Behavior

When created a new entry, if you want to download the Favicon you need to first enter the URL. Then click Icon, and then click 'Download Favicon'.

Context

If someone wants to use favicons for their entries, chances are they will want to do it every time they want to add a new entry. No reason for extra steps to do this.
I see there is a similar feature request to have an item in the Tools menu to download all Favicons, so this feature request is slightly different.
@droidmonkey
Copy link
Member

This will not happen since we are taking the position that any network action is due to deliberate user request.

@oxysoft
Copy link

oxysoft commented May 28, 2018 •
edited
Loading

Please re-open this and make it a configurable option. I hate having to switch tab to click "Download favicon" every single time. It's a small thing but it is really annoying...

@droidmonkey
Copy link
Member

I'd rather add a button next to the url field that triggers a favicon download.

@oxysoft
Copy link

oxysoft commented May 29, 2018 •
edited
Loading

I'm okay with that compromise! Would save me the extra click that I have to do every single time anyway.

@droidmonkey droidmonkey changed the title Automatic Favicon Download on Creation of New Entry Add favicon download button next to URL field in entry edit May 29, 2018
@droidmonkey droidmonkey reopened this May 29, 2018
@droidmonkey droidmonkey self-assigned this May 29, 2018
@droidmonkey droidmonkey added this to the v2.4.0 milestone May 29, 2018
kneitinger added a commit to kneitinger/keepassxc that referenced this issue Oct 31, 2018
@kneitinger
Add favicon fetch button next to entry's url edit textbox
31b5271 
When WITH_XC_NETWORKING is defined, create a QToolButton beside
the Edit Entry -> Entry -> URL, which when pressed, acts as though the
Edit Entry -> Icon -> Download Favicon button is pressed.  This button
is disabled (grayed-out) when the URL text is empty, and enabled when
the text is present.

Fixes keepassxreboot#936
@kneitinger kneitinger mentioned this issue Oct 31, 2018
Merged
droidmonkey pushed a commit to kneitinger/keepassxc that referenced this issue Nov 24, 2018
@kneitinger @droidmonkey
Add favicon fetch button next to entry's url edit textbox
138f6cc 
When WITH_XC_NETWORKING is defined, create a QToolButton beside
the Edit Entry -> Entry -> URL, which when pressed, acts as though the
Edit Entry -> Icon -> Download Favicon button is pressed.  This button
is disabled (grayed-out) when the URL text is empty, and enabled when
the text is present.

Fixes keepassxreboot#936
droidmonkey pushed a commit that referenced this issue Nov 24, 2018
@kneitinger @droidmonkey
Add favicon fetch button next to entry's url edit textbox (#2439)
a90a577 
When WITH_XC_NETWORKING is defined, create a QToolButton beside the Edit Entry -> Entry -> URL, which when pressed, acts as though the Edit Entry -> Icon -> Download Favicon button is pressed.  This button is disabled (grayed-out) when the URL text is empty, and enabled when the text is present.

Fixes #936

* Add favicon download button 
* Remove the progress dialog that appears when
downloading an entry's URL's favicon since (when working correctly) it disappears before it can be read. When downloading icons from the button
located next to the URL text box, display a message panel that confirms the download was a success.

* Do not show successful icon download msg if icon alread exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
user interface
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

Add favicon fetch button next to entry's url edit textbox kneitinger/keepassxc
3 participants
@droidmonkey @oxysoft @unimpededglare