Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake warning about compatibility min version #10155

Closed

Conversation

dmaslenko
Copy link
Contributor

@dmaslenko dmaslenko commented Jan 7, 2024

What

Upgraded the min version from 3.3.0 to 3.5.0. For now the latest version is 3.28.1.

Why

To fix this warning message:

CMake Deprecation Warning at CMakeLists.txt:17 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Screenshots

N/A

Testing strategy

  • Run any make command, for example, make format

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

[What]
  Upgraded the min version from 3.3.0 to 3.5.0.

[Why]
To fix this warning message:
  Compatibility with CMake < 3.5 will be removed from a future version of CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
@droidmonkey
Copy link
Member

We are bumping it already in #10088

@droidmonkey droidmonkey closed this Jan 7, 2024
@dmaslenko dmaslenko deleted the fix/cmake_version_warning branch January 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants