Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing stat file for polkit #10350

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix parsing stat file for polkit #10350

merged 1 commit into from
Mar 29, 2024

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested with various errors in the file and with an actual stat file

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.74%. Comparing base (267928d) to head (2421b70).

Files Patch % Lines
src/gui/osutils/nixutils/NixUtils.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10350      +/-   ##
===========================================
- Coverage    63.75%   63.74%   -0.01%     
===========================================
  Files          362      362              
  Lines        43997    44004       +7     
===========================================
  Hits         28048    28048              
- Misses       15949    15956       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey force-pushed the fix/polkit-procstat branch from 2e3f96e to 2421b70 Compare March 9, 2024 23:50
@rgarcia89
Copy link

Any update when this will be merged?

@droidmonkey droidmonkey merged commit 60908d4 into develop Mar 29, 2024
10 of 11 checks passed
@droidmonkey droidmonkey deleted the fix/polkit-procstat branch March 29, 2024 10:29
@rgarcia89
Copy link

@droidmonkey is the fix included in the latest build?
https://snapshot.keepassxc.org/latest/

If so - I cannot confirm it to be working now. I am getting the same error in the UI as before, with the difference that no logs are being produced

@droidmonkey
Copy link
Member Author

It should be, yes

@droidmonkey
Copy link
Member Author

@rgarcia89 you might be running into this issue: #10523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants