Make notes hidden by default #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheZ3ro
force-pushed
the
feature/hide_notes
branch
from
96d6ccd
to
ad76bf0
Compare
TheZ3ro
force-pushed
the
feature/hide_notes
branch
from
ad76bf0
to
ccff5e3
Compare
droidmonkey
approved these changes
Oct 26, 2017
weslly
approved these changes
Oct 26, 2017
Fixed width, and a smaller font size, make for easier readability in the notes section.
There is a simple checkbox that allows your notes to become visible again. This is always disabled by default, as the use case referenced in issue #342 (and my own use case) has confidential data in that field. Passes all tests (YubiKey is N/A) on Ubuntu 16.04.2 with Qt 5.5.1.
The alignment is a bit off, however. A better option may be simply disabling the QPlainTextEdit widget and stashing the actual notes in another buffer somewhere.
TheZ3ro
force-pushed
the
feature/hide_notes
branch
from
ccff5e3
to
9840470
Compare
19 tasks
This was referenced Oct 31, 2017
phoerious
added a commit
that referenced
this pull request
Feb 27, 2018
- Add support for KDBX 4.0, Argon2 and ChaCha20 [#148, #1179, #1230, #1494] - Add SSH Agent feature [#1098, #1450, #1463] - Add preview panel with details of the selected entry [#879, #1338] - Add more and configurable columns to entry table and allow copying of values by double click [#1305] - Add KeePassXC-Browser API as a replacement for KeePassHTTP [#608] - Deprecate KeePassHTTP [#1392] - Add support for Steam one-time passwords [#1206] - Add support for multiple Auto-Type sequences for a single entry [#1390] - Adjust YubiKey HMAC-SHA1 challenge-response key generation for KDBX 4.0 [#1060] - Replace qHttp with cURL for website icon downloads [#1460] - Remove lock file [#1231] - Add option to create backup file before saving [#1385] - Ask to save a generated password before closing the entry password generator [#1499] - Resolve placeholders recursively [#1078] - Add Auto-Type button to the toolbar [#1056] - Improve window focus handling for Auto-Type dialogs [#1204, #1490] - Auto-Type dialog and password generator can now be exited with ESC [#1252, #1412] - Add optional dark tray icon [#1154] - Add new "Unsafe saving" option to work around saving problems with file sync services [#1385] - Add IBus support to AppImage and additional image formats to Windows builds [#1534, #1537] - Add diceware password generator to CLI [#1406] - Add --key-file option to CLI [#816, #824] - Add DBus interface for opening and closing KeePassXC databases [#283] - Add KDBX compression options to database settings [#1419] - Discourage use of old fixed-length key files in favor of arbitrary files [#1326, #1327] - Correct reference resolution in entry fields [#1486] - Fix window state and recent databases not being remembered on exit [#1453] - Correct history item generation when configuring TOTP for an entry [#1446] - Correct multiple TOTP bugs [#1414] - Automatic saving after every change is now a default [#279] - Allow creation of new entries during search [#1398] - Correct menu issues on macOS [#1335] - Allow compilation on OpenBSD [#1328] - Improve entry attachments view [#1139, #1298] - Fix auto lock for Gnome and Xfce [#910, #1249] - Don't remember key files in file dialogs when the setting is disabled [#1188] - Improve database merging and conflict resolution [#807, #1165] - Fix macOS pasteboard issues [#1202] - Improve startup times on some platforms [#1205] - Hide the notes field by default [#1124] - Toggle main window by clicking tray icon with the middle mouse button [#992] - Fix custom icons not copied over when databases are merged [#1008] - Allow use of DEL key to delete entries [#914] - Correct intermittent crash due to stale history items [#1527] - Sanitize newline characters in title, username and URL fields [#1502] - Reopen previously opened databases in correct order [#774] - Use system's zxcvbn library if available [#701] - Implement various i18n improvements [#690, #875, #1436]
|
FYI: As of right now (KeepassXC 2.3.1), the Notes field is not monospaced on Mac (OSX 10.13.3), though the password one is. From my naive reading of the commits, the password font is set in a very different way from the way the notes field is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization of #541
All credit to @grim210
Description
I prefer the notes section to be fixed width (#540). When searching for an issue on the issue tracker, I found #342, which seems like it would be easy to fix while I was working on my own issue. Overall, it was a simple fix for both.
Motivation and context
Commit 636b3a0 fixes the issue that I created: #540.
Commit b9531a7 fixes issue #342.
How has this been tested?
Tried on existing database (my personal one, a few years old), and on a fresh database that was created for the screenshots below. Notes persisted through save. Disabling the notes after writing them does not erase them.
Tested on Ubuntu MATE 16.04.2 amd64, with Qt 5.5.1. All tests in the 'tests' directory were passed (except the YubiKey ones; I don't have one). There were no apparent side effects during testing.
Screenshots (if appropriate):
This is what the entry looks like by default:
When the notes section has been enabled, it looks like this:
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]