Refactor YubiKey key to avoid deadlock #11703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add mutex to get m_connectedKeys - Fix deadlock when the app uses Quick Unlock and the YubiKey is unplugged
droidmonkey
reviewed
Jan 29, 2025
droidmonkey
approved these changes
Feb 1, 2025
droidmonkey
added
high priority 🚨
feature: Hardware Keys
pr: bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application freezes if the Quick Unlock feature is activated, your database uses a composed password (password + YubiKey), and you try to Unlock Database while the YubiKey is unplugged.
This issue is related to a deadlock, which is fixed in this PR.
steps to reproduce:
Result: The application freezes.
Expected: The application is working
Screenshots
Testing strategy
Manual Testing
Type of change