Add AppImage update information #1228
Conversation
AppImage-Recipe.sh
Outdated
| @@ -38,6 +38,10 @@ export ARCH=x86_64 | |||
|
|
|||
| mkdir -p $APP.AppDir | |||
| wget -q https://github.com/AppImage/AppImages/raw/master/functions.sh -O ./functions.sh | |||
|
|
|||
| # allow overriding of appimagetool parameters, see https://github.com/AppImage/AppImageKit/issues/549 | |||
| sed -i 's/"\$appimagetool" -/"$appimagetool" $@ -/' ./functions.sh | |||
There was a problem hiding this comment.
Please send a PR for this in the AppImage/AppImages project. Thanks!
|
You shouldn't have to install zsync by the way. It comes bundled with appimagetool. |
|
I was too lazy to check where I need to call it from. It's not in the PATH. |
|
Oh, so you need it for something other than appimagetool? |
|
Our recipe moves the AppImage around and deletes the glibc version from the filename. Therefore the filename and URL stored in the auto-generated zsync file doesn't match the actual filename anymore. Hence I simply regenerate it afterwards. It's a dirty hack, but it works. Perhaps that's not needed anymore if you merge AppImageCommunity/pkg2appimage#285 |
|
Merged. |
phoerious
force-pushed
the
hotfix/1157-appimageupdate
branch
from
e452f1f
to
9f886a7
Compare
|
Thanks. I updated my PR here to throw away the obsolete generate_type2_appimage and zsync fixes. |
phoerious
force-pushed
the
hotfix/1157-appimageupdate
branch
from
9f886a7
to
ce69ba3
Compare
phoerious
force-pushed
the
hotfix/1157-appimageupdate
branch
from
ce69ba3
to
7a6b321
Compare
- Prevent database corruption when locked [#1219] - Fixes apply button not saving new entries [#1141] - Switch to Consolas font on Windows for password edit [#1229] - Multiple fixes to AppImage deployment [#1115, #1228] - Fixes multiple memory leaks [#1213] - Resize message close to 16x16 pixels [#1253]
- Prevent database corruption when locked [#1219] - Fixes apply button not saving new entries [#1141] - Switch to Consolas font on Windows for password edit [#1229] - Multiple fixes to AppImage deployment [#1115, #1228] - Fixes multiple memory leaks [#1213] - Resize message close to 16x16 pixels [#1253]
Description
This patch resolves #1157 by embedding update information into the AppImage.
How has this been tested?
./KeePassXC-*.AppImageshows the correct update information according to the specification. The actual AppImageUpdate tool could not be tested, because it crashes.Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]