Fix release-tool on macOS and add notarisation #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
hotfix/macos-release-tool
branch
5 times, most recently
from
1d779a2 to
133f369
Compare
phoerious
force-pushed
the
hotfix/macos-release-tool
branch
from
133f369 to
3e7386c
Compare
droidmonkey
approved these changes
Nov 9, 2019
phoerious
added a commit
that referenced
this pull request
Nov 11, 2019
Added - Add programmatic use of the EntrySearcher [#3760] - Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824] - macOS: Add ability to perform notarization of built package [#3827] Changed - Reduce file hash checking to every 30 seconds to correct performance issues [#3724] - Correct formatting of notes in entry preview widget [#3727] - Improve performance and UX of database statistics page [#3780] - Improve interface for key file selection to discourage use of the database file [#3807] - Hide Auto-Type sequences column when not needed [#3794] - macOS: Revert back to using Carbon API for hotkey detection [#3794] - CLI: Do not show protected fields by default [#3710] Fixed - Secret Service: Correct issues interfacing with various applications [#3761] - Fix building without additional features [#3693] - Fix handling TOTP secret keys that require padding [#3764] - Fix database unlock dialog password field focus [#3764] - Correctly label open databases as locked on launch [#3764] - Prevent infinite recursion when two databases AutoOpen each other [#3764] - Browser: Fix incorrect matching of invalid URLs [#3759] - Properly stylize the application name on Linux [#3775] - Show application icon on Plasma Wayland sessions [#3777] - macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
The release-tool had bugs on macOS which I always needed to hotfix while building releases. This PR finally fixes those once and for all. The main issues were an outdated target platform, a non-working sandbox entitlement configuration, and a wrong path to the entitlements file in the codesign command.
In addition to fixing these issues, this PR also adds notarisation capabilities, so hopefully Apple will finally shut up about our app not being tested for malware.
For 2.6 we can also look into enabling the sandbox. Right now, there is no quick way to make the browser extension work when KeePassXC is sandboxed. When we are doing that, we should also change the application identifier from
org.keepassx.keepassxctoorg.keepassxc.keepassxc.Checklist:
-DWITH_ASAN=ON. [REQUIRED]