Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret Service: cleanup and fix crash #5660

Merged
merged 6 commits into from
Nov 16, 2020
Merged

Secret Service: cleanup and fix crash #5660

merged 6 commits into from
Nov 16, 2020

Commits on Nov 13, 2020

  1. FdoSecrets: refactor DBus registration error handling

    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    000e182 View commit details
    Browse the repository at this point in the history

  2. FdoSecrets: fix typos

    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    f5caf39 View commit details
    Browse the repository at this point in the history

  3. FdoSecrets: simplify collection internal states 

    This gets rid of the m_registered state, so whenever there is a valid m_backend, it is guaranteed to be registered already.

While at it, this commit also improves DBusObject::registerWithPath a little bit by allowing properly registering multiple paths using the same adaptor, mostly for supporting Collection aliases.

Now when DBus registration fails, the code does not go into an inconsistent state or crash.
    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    804a3b6 View commit details
    Browse the repository at this point in the history

  4. FdoSecrets: handle corner cases in collection dbus names, fix keepass… 

    …xreboot#5279

- Use completeBaseName rather than baseName to ensure nonempty name
- Handle two databases have the same name
- Cleanup Service::onDatabaseTabOpened logic
    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a651d70 View commit details
    Browse the repository at this point in the history

  5. FdoSecrets: code formatting

    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    7f85eb7 View commit details
    Browse the repository at this point in the history

  6. FdoSecrets: fix signal connections

    @Aetf
    Aetf committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    9f41189 View commit details
    Browse the repository at this point in the history