CLI: Implement Search command and remove Group::locate #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce search CLI command to replace locate command. Search can provide the same functionality but in a more fine-grained fashion * Replace use of Group::locate in code: Use EntrySearcher in clip cli command best-match option. This removes the matching against group hierarchy of an entry which is kind of nonsense as clip expects exactly one match. Matching against groups can be done using search command. * Remove obsolete Group::locate method
droidmonkey
approved these changes
Aug 22, 2021
droidmonkey
changed the title
5 tasks
|
locate is used by AlfredApp and Raycast KeePassXC extensions. |
|
@witeshadow you can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group::locate does not use EntrySearcher and has a weird behaviour.
As discussed here (#6797) I refactored cli code to use EntrySearcher and removed Group::locate completely.
It changes behaviour of the clip command as it doesn't match against group hierarchy anymore when used with best-match option but this should stay mostly unnoticed because matching against group names is likely to result in multiple entries being found anyway.
Testing strategy
Added tests for search command
Available tests still pass without error
Type of change