Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db statistic output to CLI db-info command. #7032

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

glysbaysb
Copy link
Contributor

Fixes #6920

Allow the user to also see the statistics while using the cli

Code modifications.

A small refactor, moving an internal class to it's own file and using it from one additional place

Testing strategy

I have amended an existing unit test

Type of change

  • ✅ New feature (change that adds functionality)

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #7032 (77c62a8) into develop (6c4a82b) will increase coverage by 0.18%.
The diff coverage is 80.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7032      +/-   ##
===========================================
+ Coverage    64.08%   64.26%   +0.18%     
===========================================
  Files          335      336       +1     
  Lines        42322    42344      +22     
===========================================
+ Hits         27119    27210      +91     
+ Misses       15203    15134      -69     
Impacted Files Coverage Δ
src/core/PasswordHealth.h 100.00% <ø> (ø)
src/gui/reports/ReportsWidgetStatistics.cpp 11.11% <0.00%> (+4.59%) ⬆️
src/core/DatabaseStats.cpp 76.27% <76.27%> (ø)
src/cli/Info.cpp 97.37% <100.00%> (+2.92%) ⬆️
src/core/Entry.cpp 83.91% <0.00%> (-0.21%) ⬇️
src/core/PasswordHealth.cpp 56.19% <0.00%> (+26.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4a82b...77c62a8. Read the comment docs.

@glysbaysb glysbaysb force-pushed the 6920-cli-stats branch 4 times, most recently from 94bc82b to 3b92154 Compare October 9, 2021 22:32
Copy link
Member

@louib louib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR! I added a few comments, but it's looking good overall.

src/cli/Info.cpp Outdated Show resolved Hide resolved
src/core/DatabaseStats.h Outdated Show resolved Hide resolved
src/core/DatabaseStats.h Outdated Show resolved Hide resolved
Copy link
Member

@louib louib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! Not sure why the MacOS tests are failing though...

tests/TestCli.cpp Outdated Show resolved Hide resolved
@droidmonkey droidmonkey merged commit d16fc2d into keepassxreboot:develop Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display basic statistics from the command line.
4 participants