-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db statistic output to CLI db-info command. #7032
Conversation
1337571
to
c03817e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7032 +/- ##
===========================================
+ Coverage 64.08% 64.26% +0.18%
===========================================
Files 335 336 +1
Lines 42322 42344 +22
===========================================
+ Hits 27119 27210 +91
+ Misses 15203 15134 -69
Continue to review full report at Codecov.
|
94bc82b
to
3b92154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR! I added a few comments, but it's looking good overall.
cdb0894
to
f116eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job! Not sure why the MacOS tests are failing though...
f116eb2
to
c1963cd
Compare
c1963cd
to
77c62a8
Compare
Fixes #6920
Allow the user to also see the statistics while using the cli
Code modifications.
A small refactor, moving an internal class to it's own file and using it from one additional place
Testing strategy
I have amended an existing unit test
Type of change