Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Overwrite attachment" confirmation dialog. #7083

Conversation

libklein
Copy link
Contributor

Fixes #7054.

Adds a confirmation dialog if adding a file attachment to an entry would cause an existing attachment to be overwritten.

Screenshots

The dialog

Testing strategy

Tested with a test database.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@libklein
Copy link
Contributor Author

Would you guys mind adding the "Hacktoberfest" label?

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #7083 (6b496d0) into develop (9aa30c4) will increase coverage by 0.18%.
The diff coverage is 27.33%.

❗ Current head 6b496d0 differs from pull request most recent head fe7edf9. Consider uploading reports for the commit fe7edf9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7083      +/-   ##
===========================================
+ Coverage    63.77%   63.95%   +0.18%     
===========================================
  Files          330      330              
  Lines        41857    41773      -84     
===========================================
+ Hits         26691    26712      +21     
+ Misses       15166    15061     -105     
Impacted Files Coverage Δ
src/browser/BrowserAction.h 100.00% <ø> (ø)
src/browser/BrowserService.cpp 27.42% <0.00%> (-0.60%) ⬇️
src/browser/BrowserService.h 100.00% <ø> (ø)
src/browser/BrowserSettings.cpp 53.33% <ø> (+29.30%) ⬆️
src/browser/BrowserSettings.h 100.00% <ø> (ø)
src/format/HtmlExporter.cpp 0.00% <0.00%> (ø)
src/gui/PasswordGeneratorWidget.cpp 76.24% <0.00%> (-0.76%) ⬇️
src/gui/entry/EntryAttachmentsWidget.cpp 27.13% <0.00%> (-2.12%) ⬇️
src/browser/BrowserAction.cpp 22.44% <35.71%> (+0.97%) ⬆️
src/fdosecrets/objects/Item.cpp 85.81% <87.80%> (+0.41%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f2bd4...fe7edf9. Read the comment docs.

@droidmonkey
Copy link
Member

I merged the two functions into one, much better! Also fixed up the wording to be more direct.

@droidmonkey droidmonkey force-pushed the bugfix/7054-overwrite-attachment-confirmation branch from 6b496d0 to fe7edf9 Compare October 25, 2021 02:47
@droidmonkey droidmonkey merged commit 20db504 into keepassxreboot:develop Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachment overwritten without warning
3 participants