Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Agent: Fix Windows agent selection, radio buttons #7764

Merged

Conversation

hifi
Copy link
Member

@hifi hifi commented Apr 2, 2022

When we added support for having multiple agents enabled at the same time on Windows the unfortunate default was that no agents were enabled. This is really confusing.

Now Pageant is (again) the default and you can't create a combination that would have integration enabled but no agents.

Partially helps with #7473 but this also adds a new translation string, unfortunately.

Screenshots

image

Testing strategy

Quickly by hand that all positions of the radio selection were correctly saved to config file and that on first launch Pageant was selected.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #7764 (53d88df) into develop (aca197a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #7764      +/-   ##
===========================================
- Coverage    64.31%   64.29%   -0.02%     
===========================================
  Files          339      339              
  Lines        43450    43451       +1     
===========================================
- Hits         27943    27934       -9     
- Misses       15507    15517      +10     
Impacted Files Coverage Δ
src/core/Config.cpp 89.70% <ø> (ø)
src/sshagent/AgentSettingsWidget.cpp 62.00% <100.00%> (+0.78%) ⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 56.06% <0.00%> (-3.03%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️
src/core/Entry.cpp 82.59% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca197a...53d88df. Read the comment docs.

@hifi hifi force-pushed the fix/sshagent-windows-selection branch from 560cd1a to 53d88df Compare April 2, 2022 09:36
@droidmonkey droidmonkey merged commit 2b8d670 into keepassxreboot:develop Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants