Normalize path (slashes to be precise) when opening a database or saving the last used database paths (Fixes #7821) #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the last used database paths (#7821)
phoerious
approved these changes
Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## develop #7864 +/- ##
===========================================
+ Coverage 64.31% 64.31% +0.01%
===========================================
Files 339 339
Lines 43404 43430 +26
===========================================
+ Hits 27911 27930 +19
- Misses 15493 15500 +7
Continue to review full report at Codecov.
|
phoerious
approved these changes
Apr 12, 2022
t-h-e
pushed a commit
to t-h-e/keepassxc
that referenced
this pull request
Sep 8, 2022
…ing the last used database paths (keepassxreboot#7864) Fixes keepassxreboot#7821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the funny behavior described in issue #7821.
To summarize, depending on how you load a database in Windows, you will find the path (to the database) twice in the
Recent Databasesmenu entry. The only difference between the two entries would be the slashes.Testing strategy
As I don't have a windows environment to test this small change, I don't really know how to test it for windows (because it is a windows only bug). So my question here is, how do you test your code for linux and windows?
Type of change