FdoSecrets: skip entries in recycle bin when searching

[Aetf]

When the recycle bin is under the exposed group, searching will return entries in the recycle bin.

fix #7933, replaces #7850

Testing strategy

Added unit test

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[codecov-commenter]

Codecov Report

Merging #8021 (9a2f6ae) into develop (a4d4adb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #8021      +/-   ##
===========================================
- Coverage    64.29%   64.29%   -0.00%     
===========================================
  Files          339      339              
  Lines        43431    43433       +2     
===========================================
+ Hits         27923    27924       +1     
- Misses       15508    15509       +1     

Impacted Files	Coverage Δ
src/fdosecrets/objects/Collection.h	0.00% <ø> (ø)
src/fdosecrets/objects/Collection.cpp	84.84% <100.00%> (+0.03%)	⬆️
src/fdosecrets/objects/Service.cpp	82.80% <100.00%> (+0.05%)	⬆️
src/core/FileWatcher.cpp	85.54% <0.00%> (-1.20%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d4adb...9a2f6ae. Read the comment docs.

[bionade24]

When will a release or a backport of this fix come out?

[droidmonkey]

@Aetf In general I don't like leaving naked Q_ASSERT(pointer) checks because they will lead to an undiagnosed crash if they are hit in release build. We really should consider graceful exists and error messages (when necessary) for release builds.

[Aetf]

@Aetf In general I don't like leaving naked Q_ASSERT(pointer) checks because they will lead to an undiagnosed crash if they are hit in release build. We really should consider graceful exists and error messages (when necessary) for release builds.

Will keep that in mind!

[bionade24]

When will there be a new release with this fix or a backport of this bugfix?

[droidmonkey]

You can use it right now at https://snapshot.keepassxc.org

[michaelk83]

You can also just clear the recycle bin, or define a separate group for FdoSecrets that doesn't include the recycle bin.