Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Type: PICKCHARS can specify attribute and ignore BEEP #8118

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested manually

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)
  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added feature: Auto-Type pr: backport pending Pull request yet to be backported to a previous release labels Jun 6, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Jun 6, 2022
@droidmonkey droidmonkey requested a review from phoerious June 6, 2022 01:57
* Fix #7726 - Ignore BEEP Auto-Type token when it includes spaces and numbers as well
* Close #8103 - Allow specifying specific attribute to use with PICKCHARS. If none specified, it defaults to Password.
@droidmonkey droidmonkey force-pushed the feature/pickchars-attribute branch from 9e31dd0 to 477b0e1 Compare June 6, 2022 02:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #8118 (477b0e1) into develop (bc0a5a9) will decrease coverage by 0.02%.
The diff coverage is 17.65%.

@@             Coverage Diff             @@
##           develop    #8118      +/-   ##
===========================================
- Coverage    64.44%   64.42%   -0.02%     
===========================================
  Files          339      339              
  Lines        43653    43664      +11     
===========================================
- Hits         28132    28129       -3     
- Misses       15521    15535      +14     
Impacted Files Coverage Δ
src/autotype/AutoType.cpp 69.67% <17.65%> (-2.40%) ⬇️
src/core/Entry.cpp 82.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0a5a9...477b0e1. Read the comment docs.

@droidmonkey droidmonkey merged commit 20a2a96 into develop Jun 9, 2022
@droidmonkey droidmonkey deleted the feature/pickchars-attribute branch June 9, 2022 14:05
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PICKCHARS for other strings Ignore BEEP placeholder when validating Auto-Type
3 participants