Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when trying to close database during unlock #8144

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

droidmonkey
Copy link
Member

With this fix, if the user tries to close the database during unlock we will just ignore that request.

Testing strategy

Tested on Windows

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Fix #7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
@droidmonkey droidmonkey added this to the v2.7.2 milestone Jun 12, 2022
@droidmonkey droidmonkey requested a review from phoerious June 12, 2022 20:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

Merging #8144 (9b92cc8) into develop (a2aac70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #8144   +/-   ##
========================================
  Coverage    64.40%   64.40%           
========================================
  Files          339      339           
  Lines        43682    43685    +3     
========================================
+ Hits         28131    28134    +3     
  Misses       15551    15551           
Impacted Files Coverage Δ
src/gui/DatabaseOpenWidget.cpp 56.65% <100.00%> (+0.38%) ⬆️
src/gui/DatabaseWidget.cpp 61.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2aac70...9b92cc8. Read the comment docs.

@droidmonkey droidmonkey merged commit b86c3e6 into develop Jun 14, 2022
@droidmonkey droidmonkey deleted the fix/crash-on-close branch June 14, 2022 09:58
@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label Jun 14, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash 💥 pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when closing tab during password processing
3 participants