Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for number of recent files #8239

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

droidmonkey
Copy link
Member

  • Expose setting to limit the number of recent files. Default is still 5, can be set from 1 to 25.
  • Also fix tab order on settings page

Screenshots

image

Testing strategy

Tested locally

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added user interface pr: backport pending Pull request yet to be backported to a previous release labels Jul 4, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Jul 4, 2022
@droidmonkey droidmonkey requested a review from phoerious July 4, 2022 20:07
* Expose setting to limit the number of recent files. Default is still 5, can be set from 1 to 25.
* Also fix tab order on settings page
@droidmonkey droidmonkey force-pushed the fix/recentfile-setting branch from 82b9638 to ec24646 Compare July 4, 2022 20:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #8239 (ec24646) into develop (6b05b84) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #8239      +/-   ##
===========================================
- Coverage    64.45%   64.45%   -0.00%     
===========================================
  Files          339      339              
  Lines        43706    43709       +3     
===========================================
  Hits         28170    28170              
- Misses       15536    15539       +3     
Impacted Files Coverage Δ
src/gui/ApplicationSettingsWidget.cpp 51.86% <33.33%> (-0.15%) ⬇️
src/core/Entry.cpp 83.67% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b05b84...ec24646. Read the comment docs.

@droidmonkey droidmonkey merged commit dab6d94 into develop Jul 11, 2022
@droidmonkey droidmonkey deleted the fix/recentfile-setting branch July 11, 2022 10:55
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants