Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase entropy required for a "good" rating to 75. #8523

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Increase entropy required for a "good" rating to 75. #8523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/core/PasswordHealth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ PasswordHealth::Quality PasswordHealth::quality() const
return Quality::Bad;
} else if (m_score < 40) {
return Quality::Poor;
} else if (m_score < 65) {
} else if (m_score < 75) {
return Quality::Weak;
} else if (m_score < 100) {
return Quality::Good;
Expand Down Expand Up @@ -160,8 +160,8 @@ QSharedPointer<PasswordHealth> HealthChecker::evaluate(const Entry* entry) const

// Don't allow re-used passwords to be considered "good"
// no matter how great their entropy is.
if (health->score() > 64) {
health->setScore(64);
if (health->score() > 74) {
health->setScore(74);
}
}

Expand All @@ -181,8 +181,8 @@ QSharedPointer<PasswordHealth> HealthChecker::evaluate(const Entry* entry) const
// reduce the score by 2 points for every day that
// we get closer to expiry. days<=0 has already
// been handled above ("isExpired()").
if (health->score() > 60) {
health->setScore(60);
if (health->score() > 70) {
health->setScore(70);
}

health->adjustScore((30 - days) * -2);
Expand Down