Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: second fix for linked socket path #8704

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested on Ubuntu with 2.70 upgraded to this commit

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added bug feature: Browser pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@droidmonkey droidmonkey added this to the v2.7.4 milestone Oct 29, 2022
@droidmonkey
Copy link
Member Author

droidmonkey commented Oct 29, 2022

The only downside is that downgrading to anything less than 2.7.4 will break browser integration again. Maybe it is a good idea to remove this link when KeePassXC closes. @varjolintu thoughts? I am not overly concerned, but maybe adding to the troubleshooting guide for linux to manually delete the socket locations as a troubleshooting step.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (4030dbc) to head (291ab89).
Report is 338 commits behind head on develop.

Files with missing lines Patch % Lines
src/browser/BrowserShared.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8704      +/-   ##
===========================================
- Coverage    64.43%   64.43%   -0.00%     
===========================================
  Files          341      341              
  Lines        44246    44247       +1     
===========================================
  Hits         28507    28507              
- Misses       15739    15740       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@droidmonkey droidmonkey merged commit a5dee81 into develop Oct 29, 2022
@droidmonkey droidmonkey deleted the fix/browser-socket branch October 29, 2022 18:33
@varjolintu
Copy link
Member

@droidmonkey At least we've made sure the newer versions will work. I'll add a section about deleting the socket to the troubleshooting guide.

@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser connection is broken
4 participants