test: add test for maximum history in database settings #9176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaslenko
suggested changes
Feb 28, 2023
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
c3aa79e to
6063ff0
Compare
dmaslenko
approved these changes
Mar 1, 2023
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
6063ff0 to
894d504
Compare
|
did a rebase to latest commit at develop |
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
894d504 to
9eb485b
Compare
|
did a rebase to latest commit at develop |
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
9eb485b to
b4a2425
Compare
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
b4a2425 to
476b533
Compare
|
Did a rebase to latest commit at develop |
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
476b533 to
87f45a9
Compare
|
Did a rebase to latest commit at develop |
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
87f45a9 to
2c5ba1c
Compare
|
Just a rebase to latest commit |
This commit adds a test to the TestGui::testDatabaseSettings function for the history maximum items and maximum size settings. The test opens the database settings dialog, disables the history items and size settings, saves the changes, reopens the dialog, and then cancels without making any changes to load the default values. The test ensures that the default values are loaded correctly.
jNullj
force-pushed
the
Add-gui-testing-for-database-settings-max-history
branch
from
2c5ba1c to
a83bf7e
Compare
droidmonkey
approved these changes
Jul 4, 2023
pull bot
pushed a commit
to rayou/keepassxc
that referenced
this pull request
Jul 4, 2023
…ot#9176) This commit adds a test to the TestGui::testDatabaseSettings function for the history maximum items and maximum size settings. The test opens the database settings dialog, disables the history items and size settings, saves the changes, reopens the dialog, and then cancels without making any changes to load the default values. The test ensures that the default values are loaded correctly. Co-authored-by: jNullj <jNullj@users.noreply.github.com>
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Jul 4, 2023
…ot#9176) This commit adds a test to the TestGui::testDatabaseSettings function for the history maximum items and maximum size settings. The test opens the database settings dialog, disables the history items and size settings, saves the changes, reopens the dialog, and then cancels without making any changes to load the default values. The test ensures that the default values are loaded correctly. Co-authored-by: jNullj <jNullj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to the TestGui::testDatabaseSettings function for the history maximum items and maximum size settings.
The test opens the database settings dialog, disables the history items and size settings, saves the changes, reopens the dialog, and then cancels without making any changes to load the default values.
The test ensures that the default values are loaded correctly.
This tests:
Screenshots
Example for affecting coverage in one of the files
gui/dbsettings/DatabaseSettingsWidgetGeneral.cpp
Before:
After:
Testing strategy
running all tests, i also added delays and run the script line by line in debug.
Type of change