Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember sort order in Autotype popup dialog (WIP) #9508

Conversation

martinvanzijl
Copy link
Contributor

Fixes #1684.

I hope to add screenshots and unit tests later.

Screenshots

Testing strategy

I tested as follows:

  1. Created a database with two entries
  2. Used the global auto-type shortcut key
  3. Clicked on a column header to set the sort order
  4. Closed the auto-type popup
  5. Used the global auto-type shortcut key again
  6. Checked that the sort order and column were still the same

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

This needs a minor cleanup to remove the extra enum but is otherwise gtg

@droidmonkey droidmonkey self-requested a review January 12, 2025 21:57
@droidmonkey droidmonkey force-pushed the issue-1684-autotype-popup-set-order branch from c701e8e to ee81881 Compare January 12, 2025 22:00
@droidmonkey droidmonkey merged commit 6494cdb into keepassxreboot:develop Jan 12, 2025
11 checks passed
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: backported Pull request backported to previous release user interface ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Type entry choice popup doesn't remember ordering
2 participants