Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate characters in "Also choose from" field of password generator #9803

Merged
merged 4 commits into from Jan 6, 2024
Merged

Prevent duplicate characters in "Also choose from" field of password generator #9803

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b86c622
Issue #9797 fixed
Aug 28, 2023
471acbe
Code format
Aug 29, 2023
1458473
Code format(again)
Aug 29, 2023
36c4599
Update PasswordGenerator.cpp format
droidmonkey Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/PasswordGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,10 @@ QVector<PasswordGroup> PasswordGenerator::passwordGroups() const
if (!m_custom.isEmpty()) {
PasswordGroup group;

for (auto ch : m_custom) {
group.append(ch);
for (const auto& ch : m_custom) {
if (!group.contains(ch)) {
group.append(ch);
}
}

passwordGroups.append(group);
Expand Down