fix: #4057, merged incidents #4561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4561 +/- ##
===========================================
+ Coverage 30.95% 46.65% +15.69%
===========================================
Files 93 164 +71
Lines 10534 16763 +6229
===========================================
+ Hits 3261 7821 +4560
- Misses 7273 8942 +1669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can you add a few tests to cover what was not working here? Seems like we think this is first-grade info and should make sure that it works at all times. It's pretty hard for me to understand what was not working in the first place. |
talboren
reviewed
Apr 17, 2025
| merged_incidents = db_incident.merged_incidents or [] | ||
| if isinstance(merged_incidents, list): | ||
| merged_incidents = [incident.id for incident in merged_incidents] | ||
| except DetachedInstanceError: |
auto-merge was automatically disabled
April 17, 2025 06:54
Pull request was converted to draft
Contributor
Author
|
Converting to draft to bring tests |
Member
|
@Matvey-Kuk any updates on this one? |
Member
|
@Matvey-Kuk checking in again 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4057