Skip to content

feat: workflow trigger with cel expression #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
talboren merged 28 commits into from
May 5, 2025
Merged

feat: workflow trigger with cel expression #4577

talboren merged 28 commits into from
May 5, 2025

Conversation

@talboren
Copy link
Member

@talboren talboren commented Apr 17, 2025 •
edited by Kiryous
Loading

THIS IS DEPRECATING OLD FILTERS MECHANISM IN FAVOR OF NEW CEL MECHAINSM AND MIGHT BREAK THINGS. WE DO BEST EFFORTS TO HAVE BACKWARD COMPATIBILITY BUT SOME OLD FILTERS MAY BE FLAKY

Still needs to be done:

  • Update documentation to elaborate on filters with CEL and mention that old filters is deprecated (and backwards compatibility is best-effort)
  • Make the UI show a warning when using deprecated filters
  • Announce a potentially breaking change

@talboren talboren linked an issue Apr 17, 2025 that may be closed by this pull request
[➕ Feature]: Workflow trigger with CEL expression #4547
Closed
@vercel
Copy link

vercel bot commented Apr 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview May 4, 2025 6:26pm

@talboren talboren marked this pull request as ready for review April 18, 2025 10:45
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Documentation Improvements or additions to documentation Feature A new feature labels Apr 18, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.34884% with 47 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (2bd391e) to head (c824924).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
keep/workflowmanager/workflowmanager.py 38.96% 47 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
- Coverage   46.69%   46.62%   -0.08%     
==========================================
  Files         165      165              
  Lines       17005    17050      +45     
==========================================
+ Hits         7940     7949       +9     
- Misses       9065     9101      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talboren talboren force-pushed the 4547-feature-workflow-trigger-with-cel-expression branch 2 times, most recently from cc8ad1d to 44856b4 Compare April 28, 2025 09:40
@talboren talboren force-pushed the 4547-feature-workflow-trigger-with-cel-expression branch from dc774b2 to b85279f Compare April 28, 2025 13:08
shahargl
shahargl reviewed Apr 28, 2025
View reviewed changes
shahargl
shahargl reviewed Apr 28, 2025
View reviewed changes
@shahargl
Copy link
Member

shahargl commented Apr 28, 2025

things to check (?)

  1. Trigger workflow with alert - i think it tries to extract fields from filters

@talboren talboren force-pushed the 4547-feature-workflow-trigger-with-cel-expression branch from 67611e5 to 2a543b1 Compare April 28, 2025 15:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 4, 2025
@talboren talboren requested a review from Kiryous May 4, 2025 12:34
Kiryous
Kiryous reviewed May 4, 2025
View reviewed changes
Kiryous
Kiryous reviewed May 4, 2025
View reviewed changes
@talboren talboren changed the title [wip] feat: workflow trigger with cel expression feat: workflow trigger with cel expression May 4, 2025
talboren and others added 3 commits May 4, 2025 16:34
@talboren @Kiryous
Update keep-ui/features/workflows/builder/ui/Editor/TriggerEditor.tsx
01f2266 
Co-authored-by: Kirill Chernakov <yakiryous@gmail.com>
Signed-off-by: Tal <talboren2@gmail.com>
@talboren @Kiryous
Update keep-ui/features/workflows/builder/ui/Editor/TriggerEditor.tsx
f32ef5a 
Co-authored-by: Kirill Chernakov <yakiryous@gmail.com>
Signed-off-by: Tal <talboren2@gmail.com>
@talboren
Merge branch 'main' into 4547-feature-workflow-trigger-with-cel-expre…
c9ff8b2 
…ssion
Kiryous added 2 commits May 4, 2025 15:56
@Kiryous
feat: add alert count badge to trigger editor; fixed the node data in…
eded7c7 
…consistency
@Kiryous
Merge branch '4547-feature-workflow-trigger-with-cel-expression' of g…
ccaff36 
…ithub.com:keephq/keep into 4547-feature-workflow-trigger-with-cel-expression

# Conflicts:
#	keep-ui/features/workflows/builder/ui/Editor/TriggerEditor.tsx
@talboren talboren dismissed Kiryous’s stale review May 5, 2025 06:46

He cannot approve anymore because he pushed code :)

shahargl
shahargl approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@talboren talboren merged commit 087942d into main May 5, 2025
19 checks passed
@talboren talboren deleted the 4547-feature-workflow-trigger-with-cel-expression branch May 5, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahargl shahargl shahargl approved these changes

@Kiryous Kiryous Awaiting requested review from Kiryous

@skynetigor skynetigor Awaiting requested review from skynetigor

Assignees

No one assigned

Labels

Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Workflow trigger with CEL expression

5 participants

@talboren @shahargl @Kiryous @skynetigor