Skip to content

Conversation

@Kunal-Darekar
Copy link
Contributor

Description

This PR adds user tagging functionality to incident comments, allowing users to mention other team members in comments and send them notifications.

Features

  • Users can mention others using the @ symbol in comments
  • Mentions are visually highlighted in the comment thread
  • Mentioned users receive real-time notifications
  • Support for two mention formats:
  • Keyboard navigation in the mentions dropdown

Technical Implementation

  • Added CommentMention model and database migration
  • Created MentionsInput component with autocomplete
  • Added notification system for mentions
  • Added end-to-end test for the feature

Testing

@vercel
Copy link

vercel bot commented May 4, 2025

@Kunal-Darekar is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 4, 2025
@CLAassistant
Copy link

CLAassistant commented May 4, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added Feature A new feature UI User interface related issues labels May 4, 2025
@skynetigor
Copy link
Contributor

Hey!
Quick question — since we’re already using ReactQuill, could we integrate quill-mention to handle mentions instead of building a custom input from scratch?
It seems like a lighter approach, given that Quill is already part of our stack.

@Kunal-Darekar Kunal-Darekar force-pushed the feature/incident-comment-mentions branch from ae8d96a to ecb318d Compare May 11, 2025 17:30
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 11, 2025
@Kunal-Darekar Kunal-Darekar force-pushed the feature/incident-comment-mentions branch from ecb318d to 285d531 Compare May 11, 2025 17:39
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 11, 2025
@skynetigor
Copy link
Contributor

Hi @Kunal-Darekar
When I try to run your feature I get this error:
image
Could you please check if the feature works?

…ions. Rename QuillMentionsInput to CommentInput and remove redundant MentionsInput component.
@Kunal-Darekar
Copy link
Contributor Author

Kunal-Darekar commented May 14, 2025

Screenshot (90)

@skynetigor please have a look and let me know if anything else is needed.

…ationsProvider and ManualRunWorkflowModal imports
@Kiryous Kiryous self-requested a review May 15, 2025 08:00
@hemangsk
Copy link
Contributor

hemangsk commented May 15, 2025

@Kunal-Darekar Stop stealing screenshots please
Screenshot 2025-05-15 at 4 44 43 PM

@Kunal-Darekar
Copy link
Contributor Author

@Kunal-Darekar Stop stealing screenshots please

@hemangsk , I sincerely apologize for including your PR screenshot in my submission. This was completely unintentional and an oversight on my part. I've removed the image and will be more careful with my PR documentation going forward. Thank you for bringing this to my attention.

@talboren
Copy link
Member

@Kunal-Darekar i'm closing this in favor of this first PR that was opened: #4649. If it will be rejected, we'll re-open yours. Sorry for the inconvenience.

@talboren talboren closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files. UI User interface related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: Allow tagging in Incident comment

5 participants