Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the configuration files for errors #260

Open
chalkos opened this issue Apr 18, 2017 · 0 comments
Open

Check the configuration files for errors #260

chalkos opened this issue Apr 18, 2017 · 0 comments
Milestone

Comments

@chalkos
Copy link
Contributor

chalkos commented Apr 18, 2017

Configuration files with missing or invalid configuration rules may cause unstable and unforeseen behaviour. To avoid this, the configuration files should be validated and appropriate error messages should be displayed to assist in fixing the config file.

@luis100 luis100 added this to the Unplanned milestone Jun 29, 2017
DenysShvorack pushed a commit to scopesolutions-ch/roda-in that referenced this issue Mar 21, 2018
…h of metadata form fields; 3)Updated configuration loading logic; 4)Small update to metadata.xml.

------------------------------------------------------------
1)
Submission number is not mandatory anymore, Submission office and Records creator are. Made an appropriate update fo the ARELDA template.

2)
Mainly mandatory status and length of fields are validated.

3)
For the templates and schemas added logic which overrides older files in the configuration folder. Checking only if file exsist caused that some old templates stayed and there was old UI representation for metadata form, similar with schemas, old schemas caused metadata.xml validation errors.

For other configuration files I'm not sure if they can be replaced in such way. There is an open issue in GitHub to validate configuration files, this approach could be better, but not sure about performance:
keeps#260
keeps#314

4)
Empty <schutzfrist> caused xsd validation erro for metadata.xml, now it is added only when there is a value from user.

There could be similar places in metadata.xml generation, not sure if they need an update, at least no more errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants