Skip to content

Commit

Permalink
bump up version to 0.11.4 (#255)
Browse files Browse the repository at this point in the history
And added timestamped prints in a test to help debugging an intermittent test failure only seen on GitHub CI.
  • Loading branch information
keepsimple1 authored Sep 11, 2024
1 parent e54485e commit 59c9ea2
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 7 deletions.
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# Version 0.11.4 (2024-09-10)

Bugfixes. Added checks for corrupted RR data to prevent unnecessary panics. Thanks for new
contributor @rise0chen !

Sorry that this release has a few merged small commits as I didn't know how to properly
merge in a PR that targets a fetaure branch used in another PR, instead of `main` branch.

## All changes

* e54485e add --verbose in CI test run (#254) (keepsimple1)
* f0c4c27 remove fastrand dependency from dev-test (#252) (keepsimple1)
* dff1596 Merge pull request #250 from keepsimple1/rdata-check (keepsimple1)
* 659e684 fix cargo clippy warning (keepsimple1)
* 90a2f12 Merge pull request #251 from rise0chen/rdata-check (keepsimple1)
* 6d51f55 Merge branch 'rdata-check' into rdata-check (keepsimple1)
* 1b2cf40 add a check for rr data len (keepsimple1)
* a5de799 feat: test random data (rise0chen)
* 40698a3 add test case and simplify DnsTxt::new (keepsimple1)
* fc489bd refactoring error log (keepsimple1)
* a3fad8e add a check for rr data len (keepsimple1)

# Version 0.11.3 (2024-08-23)

A release of bugfixes and refactorings.
Expand Down
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mdns-sd"
version = "0.11.3"
version = "0.11.4"
authors = ["keepsimple <keepsimple@gmail.com>"]
edition = "2018"
rust-version = "1.63.0"
Expand All @@ -25,6 +25,7 @@ socket2 = { version = "0.5.5", features = ["all"] } # socket APIs

[dev-dependencies]
env_logger = { version = "= 0.10.2", default-features = false, features= ["humantime"] }
humantime = "2.1"
rand ="0.8"
test-log = "= 0.2.14"
test-log-macros = "= 0.2.14"
22 changes: 16 additions & 6 deletions tests/mdns_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1199,8 +1199,8 @@ fn test_cache_flush_record() {
match event {
ServiceEvent::ServiceResolved(info) => {
resolved = true;
println!("Resolved a service of {}", &info.get_fullname());
println!("JLN service: {:?}", info);
timed_println(format!("Resolved a service of {}", &info.get_fullname()));
timed_println(format!("JLN service: {:?}", info));
break;
}
e => {
Expand Down Expand Up @@ -1233,10 +1233,13 @@ fn test_cache_flush_record() {
&properties[..],
)
.unwrap();
let result = server.register(my_service.clone());
let result = server.register(my_service);
assert!(result.is_ok());

println!("Re-registered with updated IPv4 addr: {}", &service_ip_addr);
timed_println(format!(
"Re-registered with updated IPv4 addr: {}",
&service_ip_addr
));

// Wait for the new registration sent out and cache flushed.
sleep(Duration::from_secs(2));
Expand All @@ -1249,7 +1252,7 @@ fn test_cache_flush_record() {
ServiceEvent::ServiceResolved(info) => {
// Verify the address flushed and updated.
let new_addrs = info.get_addresses();
println!("new address resolved: {:?}", new_addrs);
timed_println(format!("new address resolved: {:?}", new_addrs));
if new_addrs.len() == 1 {
let first_addr = new_addrs.iter().next().unwrap();
assert_eq!(first_addr, &service_ip_addr);
Expand All @@ -1258,7 +1261,7 @@ fn test_cache_flush_record() {
}
}
e => {
println!("Received event {:?}", e);
timed_println(format!("Received event {:?}", e));
}
}
}
Expand Down Expand Up @@ -1450,3 +1453,10 @@ fn test_domain_suffix_in_browse() {
assert!(mdns_client.browse("_service-name._tcp.local.").is_ok());
mdns_client.shutdown().unwrap();
}

/// A helper function to include a timestamp for println.
fn timed_println(msg: String) {
let now = SystemTime::now();
let formatted_time = humantime::format_rfc3339(now);
println!("[{}] {}", formatted_time, msg);
}

0 comments on commit 59c9ea2

Please sign in to comment.