bugfix: set address type correctly (#134)

keepsimple1 · Oct 11, 2023 · fef5409 · fef5409
1 parent 966a835
commit fef5409
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/dns_parser.rs b/src/dns_parser.rs
@@ -763,9 +763,14 @@ impl DnsOutgoing {
         )));
 
         for address in intf_addrs {
+            let t = match address {
+                IpAddr::V4(_) => TYPE_A,
+                IpAddr::V6(_) => TYPE_AAAA,
+            };
+
             self.add_additional_answer(Box::new(DnsAddress::new(
                 service.get_hostname(),
-                TYPE_A,
+                t,
                 CLASS_IN | CLASS_UNIQUE,
                 service.get_host_ttl(),
                 address,
@@ -1016,7 +1021,7 @@ impl DnsIncoming {
             // sanity check.
             if self.offset != next_offset {
                 return Err(Error::Msg(format!(
-                    "read_name: decode offset error for RData type {} record: {:?} offset: {} expected offset: {}",
+                    "read_others: decode offset error for RData type {} record: {:?} offset: {} expected offset: {}",
                     ty, &rec, self.offset, next_offset,
                 )));
             }

diff --git a/src/service_daemon.rs b/src/service_daemon.rs
@@ -1159,7 +1159,7 @@ impl Zeroconf {
                     error!("Invalid message: not query and not response");
                 }
             }
-            Err(e) => error!("Invalid incoming message: {}", e),
+            Err(e) => error!("Invalid incoming DNS message: {}", e),
         }
 
         true
-Original file line number
+Diff line change
@@ Expand Up / @@ -1159,7 +1159,7 @@ impl Zeroconf { @@
                         error!("Invalid message: not query and not response");
                     }
                 }
-                Err(e) => error!("Invalid incoming message: {}", e),
+                Err(e) => error!("Invalid incoming DNS message: {}", e),
             }
             true
@@ Expand Down @@