Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service keys must be lowercase #286

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

lyager
Copy link
Contributor

@lyager lyager commented Dec 16, 2024

Services are registered with fullname as lowercase, when moving waiting_services to active after probe, the lookup failed due to using case service name

Services are registered with fullname as lowercase, when moving
waiting_services to active after probe, the lookup failed due to using
case service name
@lyager
Copy link
Contributor Author

lyager commented Dec 16, 2024

Maybe the better solution would be to create get/set on the my_services hash?

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! LGTM!

@keepsimple1
Copy link
Owner

keepsimple1 commented Dec 17, 2024

Maybe the better solution would be to create get/set on the my_services hash?

Not sure about get/set on my_services, as it's internal data structure. I'm wondering maybe we should use lower case for the keys in the waiting_services to be consistent:

pub(crate) waiting_services: HashSet<String>,

(I will merge your current change first)

@keepsimple1 keepsimple1 merged commit 6ff9b52 into keepsimple1:main Dec 17, 2024
3 checks passed
@lyager
Copy link
Contributor Author

lyager commented Dec 17, 2024

Not sure about get/set on my_services, as it's internal data structure. I'm wondering maybe we should use lower case for the keys in the waiting_services to be consistent:

Consistency is always good :) There's also UniCase, but it might be going overboard. Thanks for the quick feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants