Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retries #139

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Jun 15, 2020

Fixes #118
This lowers the default retry count to a more reasonable number (50 > 12), and also makes it configurable.

@eytan-avisror eytan-avisror requested review from a team as code owners June 15, 2020 18:45
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          12       12           
  Lines        1469     1469           
=======================================
  Hits         1314     1314           
  Misses        108      108           
  Partials       47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cb1ec...70802ce. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 52f31e3 into keikoproj:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retries: tune max retries according to error code
2 participants