-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use IMDS for autoscaling information #357
Conversation
d8f0b45
to
0902322
Compare
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 51.44% 51.41% -0.04%
==========================================
Files 33 33
Lines 4556 4553 -3
==========================================
- Hits 2344 2341 -3
Misses 2065 2065
Partials 147 147
Continue to review full report at Codecov.
|
Signed-off-by: Jonah Back <jonah@jonahback.com>
0902322
to
26d23f3
Compare
Awesome, this makes warm pool support much easier.. |
I haven't - I believe we have a warm pool TC in the functional tests - was planning to use that to verify. I validated that the IMDS endpoint was returning the expected values on a test instance |
Signed-off-by: Jonah Back <jonah@jonahback.com>
Yes, looks like we do.. would probably good to do a quick manual test since bdd tests basic CRUD, but I believe if user data fails for any reason node will not join and test will fail, so it should be sufficient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #352