Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: migrate to TypeScript #694

Merged
merged 30 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
bfd47da
chore: rename lib to src
sheerlox Sep 10, 2023
f549c71
chore: add TS, remove typings, add typings credits, update gitignore
sheerlox Sep 10, 2023
ecd0429
chore: rename cron.js to cron.ts
sheerlox Sep 10, 2023
c8442bd
refactor: migrate cron.ts to TypeScript
sheerlox Sep 10, 2023
77a423f
ci: build project before running tests
sheerlox Sep 10, 2023
6ae54d3
revert: "test: add TS types check"
sheerlox Sep 10, 2023
7954ab0
build(npm): update package-lock.json
sheerlox Sep 10, 2023
cb009f4
ci: upgrade npm, use cache for tests & build before releasing
sheerlox Sep 10, 2023
c26a491
ci: drop testing on unsupported node version 14.x, add 20.x
sheerlox Sep 10, 2023
758d0a6
chore: rename cron.ts to index.ts
sheerlox Sep 10, 2023
4947ee1
chore: rename time.js to time.ts
sheerlox Sep 11, 2023
5872ce2
refactor: migrate time.ts to TypeScript
sheerlox Sep 11, 2023
93a3035
chore: rename job.js to job.ts
sheerlox Sep 11, 2023
26095f6
chore: temporarily disable lint script
sheerlox Sep 11, 2023
5ed5df4
refactor!: migrate job.ts to TypeScript
sheerlox Sep 11, 2023
ae84034
chore: enable strictest TypeScript mode
sheerlox Sep 24, 2023
6f81e26
build(npm): don't ship source maps with bundle
sheerlox Sep 24, 2023
61b98e0
refactor: improve time.ts typings
sheerlox Sep 24, 2023
f806e76
refactor!: improve typings
sheerlox Sep 24, 2023
ad6e690
chore: add vscode jest debug config
sheerlox Sep 24, 2023
60fd6f8
style: reconfigure linters
sheerlox Sep 24, 2023
e5f8294
refactor: migrate tests to TypeScript
sheerlox Sep 25, 2023
4ee22ed
chore: add coverage folder to .prettierignore
sheerlox Sep 25, 2023
25ca080
style: configure linting for tests
sheerlox Sep 25, 2023
3e56f80
feat!: remove superfluous time() factory function
sheerlox Sep 25, 2023
625d8f8
build: fix npm build command
sheerlox Sep 25, 2023
62d96ea
test: adjust coverage thresholds
sheerlox Sep 25, 2023
795013d
fix: restore legacy behavior after merging #685
sheerlox Sep 25, 2023
f7bf656
docs(examples): update code examples
sheerlox Sep 25, 2023
32245e4
docs(readme): update README
sheerlox Sep 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 53 additions & 18 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,25 +1,60 @@
{
"extends": [
"standard",
"plugin:jest/recommended",
"plugin:import/recommended",
"plugin:n/recommended",
"plugin:prettier/recommended",
"plugin:promise/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2018
},
"globals": {
"define": "readonly"
"project": "tsconfig.json",
"sourceType": "module"
},
"plugins": ["@typescript-eslint/eslint-plugin"],
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:@typescript-eslint/strict",
"plugin:prettier/recommended"
],
"root": true,
"env": {
"browser": true,
"es6": true,
"node": true,
"jest/globals": true
"node": true
sheerlox marked this conversation as resolved.
Show resolved Hide resolved
},
"rules": {
"jest/no-done-callback": "off"
}
"@typescript-eslint/no-unused-vars": [
"warn",
{
"argsIgnorePattern": "^_"
}
],
"@typescript-eslint/naming-convention": [
"warn",
{
"selector": ["typeLike"],
"format": ["PascalCase"]
},
{
"selector": ["variableLike", "function"],
"format": ["camelCase"],
"leadingUnderscore": "allow"
},
{
"selector": ["variable"],
"format": ["camelCase", "UPPER_CASE"]
},
{
"selector": "variable",
"types": ["boolean"],
"format": ["PascalCase"],
"prefix": ["is", "should", "has", "can", "did", "was", "will"]
}
]
},
"overrides": [
{
"files": ["tests/**/*.ts"],
"plugins": ["jest"],
"extends": ["plugin:jest/recommended", "plugin:jest/style"],
"rules": {
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/unbound-method": "off",
"jest/no-done-callback": "off"
}
}
]
}
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,41 @@
<!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types-->

## Description

<!--- Describe your changes in detail -->

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

runs-on: ubuntu-latest
env:
node-version: 18.x
node-version: 20.x

steps:
- name: Checkout project
Expand All @@ -30,6 +30,8 @@ jobs:
node-version: ${{ env.node-version }}
- name: Install packages
run: npm ci
- name: Build project
run: npm run build
- name: Run Semantic Release
run: npm run release
env:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: [14.x, 16.x, 18.x]
node: [16.x, 18.x, 20.x]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand All @@ -23,11 +23,12 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
cache: 'npm'
- name: Install packages
run: npm ci
- name: Build project
run: npm run build
- name: Check codestyle compliance
run: npm run lint
- name: Check TS types
run: npm run test:types
- name: Run tests
run: npm run test
133 changes: 130 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,130 @@
*.sw[a-z]
node_modules
coverage
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*
.pnpm-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage
*.lcov

# nyc test coverage
.nyc_output

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Snowpack dependency directory (https://snowpack.dev/)
web_modules/

# TypeScript cache
*.tsbuildinfo

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional stylelint cache
.stylelintcache

# Microbundle cache
.rpt2_cache/
.rts2_cache_cjs/
.rts2_cache_es/
.rts2_cache_umd/

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variable files
.env
.env.development.local
.env.test.local
.env.production.local
.env.local

# parcel-bundler cache (https://parceljs.org/)
.cache
.parcel-cache

# Next.js build output
.next
out

# Nuxt.js build / generate output
.nuxt
dist

# Gatsby files
.cache/
# Comment in the public line in if your project uses Gatsby and not Next.js
# https://nextjs.org/blog/next-9-1#public-directory-support
# public

# vuepress build output
.vuepress/dist

# vuepress v2.x temp and cache directory
.temp
.cache

# Docusaurus cache and generated files
.docusaurus

# Serverless directories
.serverless/

# FuseBox cache
.fusebox/

# DynamoDB Local files
.dynamodb/

# TernJS port file
.tern-port

# Stores VSCode versions used for testing VSCode extensions
.vscode-test

# yarn v2
.yarn/cache
.yarn/unplugged
.yarn/build-state.yml
.yarn/install-state.gz
.pnp.*
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CHANGELOG.md
dist/
coverage/
17 changes: 17 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"version": "1.0.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Jest Debug",
"env": { "NODE_ENV": "test" },
"program": "${workspaceFolder}/node_modules/.bin/jest",
"args": [],
"console": "integratedTerminal",
"windows": {
"program": "${workspaceFolder}/node_modules/jest/bin/jest"
}
}
]
}
Loading