Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libs for security reasons #1049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tbo47
Copy link

@tbo47 tbo47 commented Sep 17, 2024

Update libs with security issues.

Update nodejs version because one of the dependency has a restriction on nodejs>=18
https://github.com/nodejs/node-addon-api/blob/main/package.json#L484

Closes #1029

Closes #1031

@tbo47
Copy link
Author

tbo47 commented Sep 18, 2024

I'm forcing

    "node-addon-api": "^8.1.0",
    "node-gyp-build": "^4.8.2",

and it works well.

@karlhorky
Copy link

@tbo47 you can also mark this PR with the following note at the top:

Closes #1029

Since this also fixes the issues when bcrypt is installed in a project that also uses sharp, which breaks the sharp build.

@karlhorky
Copy link

@recrsn @ncb000gt it would be great to get this reviewed + merged + published, if you have a chance!

Apart from the security concerns, it's causing bcrypt to break the builds of sharp because of the outdated node-addon-api version:

I can confirm that in our first tests, the newer node-addon-api@8.1.0 version also works to build bcrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no member named errors with node-addon-api@^5
2 participants