fix: Add missing dev dependencies: prebuildify and python package distutils in CI #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/traverse <7.23.2 Severity: critical Babel vulnerable to arbitrary code execution when compiling specifically crafted malicious code - GHSA-67hx-6x53-jw92 fix available via `npm audit fix` node_modules/@babel/traverse braces <3.0.3 Severity: high Uncontrolled resource consumption in braces - GHSA-grv7-fg5c-xmjg fix available via `npm audit fix` node_modules/braces debug 4.0.0 - 4.3.0 Regular Expression Denial of Service in debug - GHSA-gxpj-cx7g-858c fix available via `npm audit fix` node_modules/debug micromatch <4.0.8 Severity: moderate Regular Expression Denial of Service (ReDoS) in micromatch - GHSA-952p-6rrq-rcjv fix available via `npm audit fix` node_modules/micromatch 4 vulnerabilities (1 low, 1 moderate, 1 high, 1 critical)
related commit 4de3ed6.
|
The repo seems abandoned, maybe someone should fork it? |
|
It's a pity that the repo is not maintained. But I'm afraid I'm not capable of taking it over. |
|
It's very much not abandoned. There is not enough critical mass of changes to warrant a new release. NAPI has served us nicely with not breaking API/ABI and most of the issues that get reported is due to firewalls or user errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebuildifywas introduced in the build script in 4de3ed6 and in the build script it is installed globally. This is not necessary and should be installed as dev dependencies and managed bynpm.During testing I added
distutilsin the Dockerfiles.distutilshas been removed from the Python standard library since 3.12 and has to be installed separately (Ref: https://docs.python.org/3.12/whatsnew/3.12.html python/cpython#95299 ). In Debian, the Python version is currently at 3.9, but the change will propagate soon in the next major version.This PR additionally fixes upstream vulnerabilities issues reported by
npm audit.