travis: use npm test only. npm install attempts to download prebu…
#450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilt node-pre-gyp binary
|
@ksmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @defunctzombie, @ncb000gt and @elliotstokes to be potential reviewers. |
|
Related: turn on travis for kelektiv/node.bcrypt.js and change badge URL in the readme |
|
LGTM What about the readme changes? |
|
0d643af has the readme changes I was referring to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm installattempts to download prebuilt node-pre-gyp binary:https://travis-ci.org/ksmyth/node.bcrypt.js/jobs/165239737#L279
Use
npm testinstead, which will build the binary.