Allow the error parameter string to contain string formatting parameters #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relates to issue #98. |
Fixing failing tests for error formatting feature. (#98)
Current coverage is 100% (diff: 100%)@@ master #107 diff @@
====================================
Files 1 1
Lines 151 215 +64
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 151 215 +64
Misses 0 0
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call to format on the
errorparameter before displaying it, passing the data into the formatter. This allows custom error messages to change from something like"Invalid user id."to"Invalid user id: {}", which would display as"Invalid user id: 9243".Please let me know if I missed something somewhere.