Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating is_valid method as suggested in the issue 134 #150

Merged

Conversation

sjortiz
Copy link
Contributor

@sjortiz sjortiz commented May 8, 2018

Originated from the issue #134

Description:
This methods returns True if the given data has passed all the validations that were specified in the given schema, returns false if not.

Considerations:

This method doesn't raise any exception and thus prevent any exception from the schema validation to pass silently

@sjortiz sjortiz force-pushed the issue-134_add_is_valid_method branch from 47abb37 to b09e332 Compare May 8, 2018 02:36
@sjortiz sjortiz force-pushed the issue-134_add_is_valid_method branch from b09e332 to b626cc9 Compare May 8, 2018 02:39
@codecov-io
Copy link

Codecov Report

Merging #150 into master will decrease coverage by 2.33%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage     100%   97.66%   -2.34%     
==========================================
  Files           1        1              
  Lines         208      214       +6     
==========================================
+ Hits          208      209       +1     
- Misses          0        5       +5
Impacted Files Coverage Δ
schema.py 97.66% <16.66%> (-2.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3054d7e...b626cc9. Read the comment docs.

@skorokithakis skorokithakis merged commit c477c33 into keleshev:master May 8, 2018
@skorokithakis
Copy link
Collaborator

Thank you!

@mlhamel
Copy link

mlhamel commented May 15, 2018

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants