Dict validation: Keep track of matched input keys #92

sjakobi · 2015-10-09T11:09:56Z

Fixes #80.

codecov-io · 2015-10-09T11:11:39Z

Current coverage is `99.37%`

Merging #92 into master will increase coverage by +0.01% as of 0988074

@@            master     #92   diff @@
======================================
  Files            1       1       
  Stmts          157     159     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            156     158     +2
  Partial          0       0       
  Missed           1       1

Review entire Coverage Diff as of 0988074

Powered by Codecov. Updated on successful CI builds.

guilload · 2015-10-09T15:10:13Z

schema.py

@@ -142,13 +143,15 @@ def validate(self, data):
                    if x is not None:
                        raise SchemaError(['Invalid value for key %r' % key] +
                                          x.autos, [e] + x.errors)
+            matched_schema_keys = set(matched.keys())


Maybe you could use 2 sets directly instead of the matched dict.

Yeah, of course. Thanks! :)

Fixes keleshev#80.

guilload reviewed Oct 9, 2015
View reviewed changes

Dict validation: Keep track of matched input keys

0335a46

Fixes keleshev#80.

sjakobi force-pushed the wrong-keys branch from 307194a to 0335a46 Compare October 9, 2015 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dict validation: Keep track of matched input keys #92

Dict validation: Keep track of matched input keys #92

sjakobi commented Oct 9, 2015

codecov-io commented Oct 9, 2015

guilload Oct 9, 2015

sjakobi Oct 9, 2015

Dict validation: Keep track of matched input keys #92

Are you sure you want to change the base?

Dict validation: Keep track of matched input keys #92

Conversation

sjakobi commented Oct 9, 2015

codecov-io commented Oct 9, 2015

Current coverage is 99.37%

guilload Oct 9, 2015

Choose a reason for hiding this comment

sjakobi Oct 9, 2015

Choose a reason for hiding this comment

Current coverage is `99.37%`