New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit.Channel #66

Merged

kelindar merged 1 commit into kelindar:main from Dreeseaw:fix-commit-channel

Jun 5, 2022

Collaborator

Dreeseaw commented Jun 5, 2022

Was messing around with CDC and caught

./collection_test.go:553:11: cannot use w (variable of type commit.Channel) as type commit.Logger in struct literal:
        commit.Channel does not implement commit.Logger (Append method has pointer receiver)

This PR fixes commit.Channel and allows it to once again implement the Logger interface. It also adds a simple replication test.


          fix commit.Channel; add replica test; fix readme

a3bba9e

kelindar approved these changes

View reviewed changes

kelindar merged commit adf3a76 into kelindar:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet