Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for unknown compressor config args #126

Merged
merged 22 commits into from
Jan 25, 2025

Conversation

keller-mark
Copy link
Owner

Fixes #125

@dblodgett-usgs
Copy link
Collaborator

Looks good. I'm rerunning the tests to see if the failure was an intermittent dependency installation issue.

@keller-mark
Copy link
Owner Author

It seems the error message mentions the stringfish package, a dependency of the qs package which provides some compression functionality. Their macOS test from 2 months ago was also failing https://github.com/traversc/stringfish/actions/runs/11992415106/job/33432216846

@keller-mark
Copy link
Owner Author

This issue mentions updating Rcpp traversc/stringfish#24 but based on the printed environment it seems up to date

@dblodgett-usgs
Copy link
Collaborator

OK -- well, let's merge this and deal with that separately? No need to get hung up for now.

@keller-mark keller-mark merged commit 2624326 into main Jan 25, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with get_item()
2 participants