Make pins owned instead of mut borrowed #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
PCD8544
struct mutably borrows pins that it uses:pcd8544/src/lib.rs
Lines 39 to 45 in fdaae48
While that might look like a good idea, putting these pins and
PCD8544
to some struct is almost impossible in Rust's type system, requiring sophisticated hacks likerental
or something based onPin
, which is high-end type system magic.Most driver crates I've seen own pins.
This change is backwards-incompatible.
See also:
Same discussion in another your crate: kellerkindt/w5500#13