-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Udp implementation and add more methods #57
Conversation
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really nice! Thanks for the changes. Some minor comments/cleanup requests, but it looks really good otherwise.
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's definitely a lot of room for improvements, however, this UDP implementation now works and for me that was more important.
You're welcome to improve on the current working implementation.
@elpiel It's not clear to me what this PR is actually fixing in the UDP API outside of adding the new functions and refactoring the code, but you claim this has resolved your issues. What issues does this PR fix? From my review, I would guess #59, but I don't see any changes that would address #46 or #44 |
Yes @ryan-summers there are a few things that this PR fixes and improves:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation on what this PR is solving, it helped me understand the purpose of this restructering. After taking a closer look, everything looks to be in order and makes sense to me. Thanks for taking the time to help me understand a bit more, and I appreciate the contribution here a lot!
@elpiel Would you be able to resolve the merge conflicts? I am happy to merge afterwards :) |
Will do. Hopefully we can improve the crate not to block while waiting for ARP response, make it async and allow usage of the interrupt pin. |
Split out from #42
set_port
andget_port
for setting and getting respectively the socket port