Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor options #386

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Sensor options #386

merged 5 commits into from
Jan 9, 2025

Conversation

kellerza
Copy link
Owner

@kellerza kellerza commented Jan 9, 2025

Continue on #377 & hopefully fixing #374

There are only a single set of sensor options. So, the order that we add these seem important. Deps can be visible if configured on all/1st inverter.

Startup sensors are used to read limited info from the inverter and make sure that the wiring/configuration is correct. By far the most issues on the repo is related to connectivity, so don't want to change this.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (7a2597f) to head (153a96b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ha_addon_sunsynk_multi/a_inverter.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   70.97%   71.01%   +0.04%     
==========================================
  Files          26       26              
  Lines        1874     1884      +10     
==========================================
+ Hits         1330     1338       +8     
- Misses        544      546       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellerza kellerza merged commit 1e498de into main Jan 9, 2025
16 checks passed
@kellerza kellerza deleted the SensorOptions branch January 9, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant