Upstream/general improvements

[maslyankov]

Improvements to sensor definitions for single and three-phase models. Ass well as new / updated sensor groups.

Sorry for big PR...

Addresses:

• Deye/Sunsync 3 phase check "Total Active Power from Side to Side of the Grid" #390
• Wrong "ON" value for "Solar Export" #381 (comment)

[maslyankov]

@kellerza Please review my handling of the issues with recursive sensor dependencies here: https://github.com/maslyankov/sunsynk/blob/main/src/ha_addon_sunsynk_multi/sensor_options.py (https://github.com/maslyankov/sunsynk/blob/39262f08ae6bd89dfefd123531e9eaebef435e48/src/ha_addon_sunsynk_multi/sensor_options.py#L49C1-L50C1)

I have not added it to this PR. I'd like to hear your thoughts on it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (79d9c13) to head (72f6203).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   70.93%   70.97%   +0.04%     
==========================================
  Files          26       26              
  Lines        1899     1902       +3     
==========================================
+ Hits         1347     1350       +3     
  Misses        552      552              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kellerza]

@kellerza Please review my handling of the issues with recursive sensor dependencies here: https://github.com/maslyankov/sunsynk/blob/main/src/ha_addon_sunsynk_multi/sensor_options.py (https://github.com/maslyankov/sunsynk/blob/39262f08ae6bd89dfefd123531e9eaebef435e48/src/ha_addon_sunsynk_multi/sensor_options.py#L49C1-L50C1)

I have not added it to this PR. I'd like to hear your thoughts on it.

The biggest drawback with the recursive method is that checking if a sensor (or its deps) is visible/first only is quite complex.

With the current implementation sensor_options they are added in the following order, and visibility/first seems depends on the order. Adding deps are also delayed (since they could be visible)

The order, as comments in the code

1. Add startup sensors to all inverters. Visible if configured anywhere.
2. Add sensors configured for all inverters
3. Add deps, usually hidden, but visible if configured on 1st inverter
4. Add sensors configured for the 1st inverter
5. Add deps for the 1st inverter, always hidden

[maslyankov]

@kellerza Please review my handling of the issues with recursive sensor dependencies here: https://github.com/maslyankov/sunsynk/blob/main/src/ha_addon_sunsynk_multi/sensor_options.py (https://github.com/maslyankov/sunsynk/blob/39262f08ae6bd89dfefd123531e9eaebef435e48/src/ha_addon_sunsynk_multi/sensor_options.py#L49C1-L50C1)
I have not added it to this PR. I'd like to hear your thoughts on it.

The biggest drawback with the recursive method is that checking if a sensor (or its deps) is visible/first only is quite complex.

With the current implementation sensor_options they are added in the following order, and visibility/first seems depends on the order. Adding deps are also delayed (since they could be visible)

The order, as comments in the code

1. Add startup sensors to all inverters. Visible if configured anywhere.
2. Add sensors configured for all inverters
3. Add deps, usually hidden, but visible if configured on 1st inverter
4. Add sensors configured for the 1st inverter
5. Add deps for the 1st inverter, always hidden

In the current implementation, do we add sensors as visible if they are defined in sensor group?

[kellerza]

In the current implementation, do we add sensors as visible if they are defined in sensor group?

Yes, the groups are expanded right at the start. Nothing depends on a group

[maslyankov]

Owner

Okay. Any other changes to add to this branch?

[kellerza]

Thanks @maslyankov !

[Doesi]

Since these changes, power sensors on my DEYE SUN 20K-SG01 HP3-EU-AM2 randomly jump to 65535 kW and -65509 kW. This has never happened before.

[proggaras]

I can confirm. Here is an example for "Inverter L1 Power":

[maslyankov]

Can you create an issue? I think I have an idea why this might happen and a PR for possible fix. Thanks.
Otherwise, these changes on my setup have allowed values larger than 32kw on different phases (which previously never worked). I also had an occasion with such spikes though.